Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] SMTP config #5124

Open
wants to merge 1 commit into
base: release/v1.1.0
Choose a base branch
from
Open

[docs] SMTP config #5124

wants to merge 1 commit into from

Conversation

Anddraca
Copy link
Contributor

@Anddraca Anddraca commented Nov 15, 2024

What changes are proposed in this pull request?

Added docs and associated images for configuring SMTP connections

Summary by CodeRabbit

  • New Features

    • Introduced a "New User Invitations" section for onboarding users via invitation links.
    • Added functionality for automatic email invitations through SMTP configuration.
  • Documentation

    • Updated documentation to clarify authentication modes and user management processes.

Copy link
Contributor

coderabbitai bot commented Nov 15, 2024

Walkthrough

The documentation for Pluggable Authentication in FiftyOne Teams has been updated to include a new section on "New User Invitations," detailing the onboarding process via invitation links. This feature allows Super Admins to create invitation links for internal mode, which can now be sent automatically via email through a configured SMTP server. The documentation clarifies the differences between legacy and internal authentication modes and notes that user invitations are not supported in internal mode.

Changes

File Change Summary
docs/source/teams/pluggable_auth.md - Added section on "New User Invitations"
- Introduced user onboarding via invitation links
- Added functionality for automatic email invitations via SMTP
- Clarified distinctions between legacy and internal authentication modes

Possibly related PRs

  • Update doc example JS Hook adding user to group #4900: This PR updates the documentation for Pluggable Authentication, which is directly related to the changes in the main PR that also focuses on user onboarding and authentication modes in the same documentation file.

Suggested labels

documentation

Suggested reviewers

  • findtopher
  • benjaminpkane

Poem

🐇 In the land of code where rabbits play,
New invitations hop in a joyful way.
With links to invite, users join the fun,
SMTP sends greetings, now everyone’s one!
So let’s celebrate this change so bright,
Pluggable Auth shines, a true delight! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (5)
docs/source/teams/pluggable_auth.md (5)

73-84: Consider adding migration and compatibility details.

The documentation would benefit from additional context about:

  • Whether this is a breaking change for existing installations
  • What happens to existing invitation methods after upgrading
  • Whether organizations need to take any action during upgrade

85-94: Add security recommendations for SMTP configuration.

Consider adding a security section that covers:

  • Best practices for securing SMTP connections (e.g., TLS requirements)
  • Recommendations for handling credentials
  • Network security considerations

109-113: Enhance error handling and troubleshooting documentation.

The preliminary check for SMTP server reachability should include:

  • Common error scenarios and their solutions
  • Specific error messages users might encounter
  • Steps to diagnose connection issues

114-117: Document email customization capabilities.

Consider adding information about:

  • Email template customization options
  • Available variables/placeholders in templates
  • Language/localization support for emails

73-122: Maintain consistent markdown formatting.

Ensure consistent formatting throughout the documentation:

  • Use consistent quote styles (backticks vs. single/double quotes)
  • Maintain consistent spacing around headers
  • Align indentation in lists
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 02ae185 and b729bc6.

⛔ Files ignored due to path filters (4)
  • docs/source/images/teams/cas/SMTP_config.png is excluded by !**/*.png, !**/*.png
  • docs/source/images/teams/cas/SMTP_config_test_email.png is excluded by !**/*.png, !**/*.png
  • docs/source/images/teams/cas/org_enable_invitations.png is excluded by !**/*.png, !**/*.png
  • docs/source/images/teams/cas/org_send_email_invitations.png is excluded by !**/*.png, !**/*.png
📒 Files selected for processing (1)
  • docs/source/teams/pluggable_auth.md (1 hunks)

can be manually sent to users. When those users click the links, they will be
added to the Organization and prompted to log in.

As of FiftyOne Teams 2.2.0, these invitation links can be automatically sent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New section

Comment on lines +90 to +93
> **NOTE:** Unless the deployment is a Managed Deployment, users must provide
> their own SMTP server to use in [internal mode](#internal-mode). This new
> functionality provides a way to authenticate and communicate with your
> existing mail server.
Copy link
Contributor

@swheaton swheaton Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we providing SMTP server to managed customers in 2.2 release?

Copy link
Contributor

@swheaton swheaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I also did not know we could use markdown, I thought RST was required 🤔
Docs looked good to me. Product will probably want to proof at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants