Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ENV DOCKER_IN_DOCKER to fix SSH conn info #51

Merged

Conversation

QueerCodingGirl
Copy link
Contributor

This fixes #46 for my docker-in-docker gitlab runner setup.

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #51 (07f3956) into master (b47d868) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   84.82%   84.82%           
=======================================
  Files           1        1           
  Lines         290      290           
=======================================
  Hits          246      246           
  Misses         44       44           
Impacted Files Coverage Δ
lib/beaker/hypervisor/docker.rb 84.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47d868...07f3956. Read the comment docs.

@ekohl
Copy link
Member

ekohl commented Aug 17, 2021

@h-haaks does #46 (comment) imply you've tested this? If so, can you approve this PR?

@h-haaks
Copy link

h-haaks commented Aug 17, 2021

@ekohl I have tested this branch in our Jenkins setup ( docker in docker ) and locally ( plain docker ) and confirm that it solves #46.
The new env var DOCKER_IN_DOCKER needs to be documented i guess.

@h-haaks
Copy link

h-haaks commented Aug 17, 2021

I don't think I'm allowed to approve PRs ...

@ekohl
Copy link
Member

ekohl commented Aug 17, 2021

Now it's a bit of bookkeeping (and the current comment is sufficient), but for the record, any logged in user is able to go to https://github.com/voxpupuli/beaker-docker/pull/51/files and use the Review changes button to approve. If you don't have permissions, then it'll show up as gray, otherwise as green.

@ekohl
Copy link
Member

ekohl commented Aug 17, 2021

I'd be OK with merging this, but I do agree this part would be nice to fix:

The new env var DOCKER_IN_DOCKER needs to be documented i guess.

@QueerCodingGirl
Copy link
Contributor Author

@ekohl could you merge and release this, please? I added a little bit of documentation.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ekohl ekohl merged commit fb69f61 into voxpupuli:master Sep 7, 2021
@QueerCodingGirl
Copy link
Contributor Author

@ekohl when is the next release planned, or could you just craft a new release right now? I really dislike having to use my fork at the moment.

@ekohl
Copy link
Member

ekohl commented Sep 9, 2021

We don't really plan releases. They go out as needed. I think we can prepare one.

@ekohl
Copy link
Member

ekohl commented Sep 13, 2021

It went out via #57. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rake beaker fail when using beaker-docker 0.8.4 in a docker in docker environment
4 participants