-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ENV DOCKER_IN_DOCKER to fix SSH conn info #51
Added ENV DOCKER_IN_DOCKER to fix SSH conn info #51
Conversation
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=======================================
Coverage 84.82% 84.82%
=======================================
Files 1 1
Lines 290 290
=======================================
Hits 246 246
Misses 44 44
Continue to review full report at Codecov.
|
@h-haaks does #46 (comment) imply you've tested this? If so, can you approve this PR? |
I don't think I'm allowed to approve PRs ... |
Now it's a bit of bookkeeping (and the current comment is sufficient), but for the record, any logged in user is able to go to https://github.com/voxpupuli/beaker-docker/pull/51/files and use the |
I'd be OK with merging this, but I do agree this part would be nice to fix:
|
@ekohl could you merge and release this, please? I added a little bit of documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@ekohl when is the next release planned, or could you just craft a new release right now? I really dislike having to use my fork at the moment. |
We don't really plan releases. They go out as needed. I think we can prepare one. |
It went out via #57. Thanks for your contribution! |
This fixes #46 for my docker-in-docker gitlab runner setup.