Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beaker-hostgenerator support for redhatfips-9-x86_64 #355

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

rhegde0722
Copy link

  • This PR adds support in beaker-hostgenerator for Redhat 9 fips image.

@rhegde0722 rhegde0722 marked this pull request as draft February 12, 2024 10:29
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (e67e9c1) 0.72% compared to head (be3c798) 0.71%.

Files Patch % Lines
lib/beaker-hostgenerator/data.rb 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #355      +/-   ##
=========================================
- Coverage    0.72%   0.71%   -0.01%     
=========================================
  Files          15      15              
  Lines        1802    1811       +9     
=========================================
  Hits           13      13              
- Misses       1789    1798       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhegde0722 rhegde0722 marked this pull request as ready for review February 12, 2024 11:26
Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given #356 I'm going to ignore the code coverage

@joshcooper joshcooper merged commit 6ecd07e into voxpupuli:master Feb 13, 2024
6 of 8 checks passed
@rhegde0722 rhegde0722 deleted the RE-16102 branch February 14, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants