Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

voxpupuli-rubocop: Require 2.7.0 #136

Merged
merged 1 commit into from
May 28, 2024
Merged

voxpupuli-rubocop: Require 2.7.0 #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2023-03-27 16:58:25 UTC using RuboCop version 1.48.1.
# on 2024-05-28 09:46:46 UTC using RuboCop version 1.63.5.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 3
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: AutoCorrect.
Lint/UselessAssignment:
Exclude:
- 'lib/beaker-rspec/helpers/serverspec.rb'
Expand All @@ -22,6 +24,7 @@ Naming/AccessorMethodName:
# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
Naming/FileName:
Exclude:
- 'Rakefile.rb'
- 'lib/beaker-rspec.rb'

# Offense count: 1
Expand Down
2 changes: 1 addition & 1 deletion beaker-rspec.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Gem::Specification.new do |s|
s.add_development_dependency 'fakefs', '>= 0.6', '< 3'
s.add_development_dependency 'minitest', '~> 5.4'
s.add_development_dependency 'rake', '~> 13.0'
s.add_development_dependency 'voxpupuli-rubocop', '~> 1.3'
s.add_development_dependency 'voxpupuli-rubocop', '~> 2.7.0'

# Run time dependencies
s.add_runtime_dependency 'beaker', '>= 4.0', '< 6'
Expand Down
6 changes: 3 additions & 3 deletions lib/beaker-rspec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@
# process options to construct beaker command string
nodesetdir = options[:nodesetdir] || File.join('spec', 'acceptance', 'nodesets')
nodesetfile = options[:nodesetfile] || File.join(nodesetdir, "#{options[:nodeset]}.yml")
fresh_nodes = options[:provision] == 'no' ? '--no-provision' : nil
fresh_nodes = (options[:provision] == 'no') ? '--no-provision' : nil
keyfile = options[:keyfile] ? ['--keyfile', options[:keyfile]] : nil
debug = options[:debug] && options[:debug] != 'no' ? ['--log-level', 'debug'] : nil
color = options[:color] == 'no' ? ['--no-color'] : nil
debug = (options[:debug] && options[:debug] != 'no') ? ['--log-level', 'debug'] : nil
color = (options[:color] == 'no') ? ['--no-color'] : nil
options_file = options[:optionsfile] ? ['--options-file', options[:optionsfile]] : nil

# Configure all nodes in nodeset
Expand Down