Use DNF for Fedora, newer Enterprise Linux #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the install_package and uninstall_package methods used Yum for all versions of Red Hat Enterprise Linux. However, RHEL has used DNF as its default package manager since version 8. This commit updates those methods to use DNF for RHEL 8, 9, and any future versions and to explicitly use Yum on RHEL versions 1-7.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1835 +/- ##
==========================================
- Coverage 74.58% 74.52% -0.07%
==========================================
Files 81 81
Lines 4506 4506
==========================================
- Hits 3361 3358 -3
- Misses 1145 1148 +3 ☔ View full report in Codecov by Sentry. |
ekohl
reviewed
Nov 22, 2023
lib/beaker/host/unix/pkg.rb
Outdated
| @@ -87,10 +87,10 @@ def install_package(name, cmdline_args = '', version = nil, opts = {}) | |||
| execute("zypper --non-interactive --gpg-auto-import-keys in #{name}", opts) | |||
| when /el-4/ | |||
| @logger.debug("Package installation not supported on rhel4") | |||
| when /amazon-2023|fedora-(2[2-9]|3[0-9])/ | |||
| when /amazon-2023|el-(8|9|1[0-9])|fedora-(2[2-9]|3[0-9])/ | |||
There was a problem hiding this comment.
Fedora 40 is about to come out. Any thoughts on assuming DNF?
when /cisco|eos|el-[1-7]-/
# yum
when /amazon|el|fedora/
# dnfThere was a problem hiding this comment.
Sounds good to me. I guess at this point,we can assume any Fedora < 22 machines running are long gone.
I'll add another commit
mhashizume
changed the title
bastelfreak
approved these changes
Nov 22, 2023
Prior to this commit, the install and uninstall methods for Fedora defaulted to using DNF as its package manager for versions greater than or equal to 22 but less than 40, and Yum for every other version. This commit configures Beaker to use DNF for every version of Fedora, as DNF has been the default package manager for Fedora for the last 8 years.
bastelfreak
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the install_package and uninstall_package methods used Yum for all versions of Red Hat Enterprise Linux. However, RHEL has used DNF as its default package manager since version 8.
This commit updates those methods to use DNF for RHEL 8, 9, and any future versions and to explicitly use Yum on RHEL versions 1-7.