(maint) permit PlatformTagContainer class #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #1839 +/- ##
=======================================
Coverage 74.94% 74.94%
=======================================
Files 82 82
Lines 4865 4865
=======================================
Hits 3646 3646
Misses 1219 1219 ☔ View full report in Codecov by Sentry. |
jonathannewman
approved these changes
Dec 13, 2023
This commit adds the PlatformTagContainer class to the HostsFileParser module so that tests can be re-run. This class was added to the 5.x series in a previous commit [1] but was not added to the 4.x branch. For context see issue 1753 [2]. [1]: 45f0bf9 [2]: voxpupuli#1753
steveax
force-pushed
the
maint-permit-PlatformTagContainer-class
branch
from
ea907e4 to
4f9854e
Compare
bastelfreak
approved these changes
Dec 15, 2023
|
original commit: 45f0bf9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the PlatformTagContainer class to the HostsFileParser module so that tests can be re-run. This class was added to the 5.x series in a previous commit 1 but was not added to the 4.x branch. For context see issue #1753