Drop support for EoL Debian/Ubuntu versions #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
force-pushed
the
debian
branch
2 times, most recently
from
0ed0c8d to
0120d97
Compare
joshcooper
reviewed
May 10, 2024
joshcooper
reviewed
May 10, 2024
|
The osx codenames can also be dropped like highsierra, we don't support those versions anymore and our packages no longer contain the codename (which is why newer mac codenames are not in the hash) |
bastelfreak
force-pushed
the
debian
branch
2 times, most recently
from
31f6af6 to
85c053a
Compare
TheMeier
approved these changes
May 11, 2024
|
@joshcooper I don't know much about the Mac OS ecosystem. Can we drop all references to their OS names? |
Yes, please do! We used to include the mac code name in the puppet-agent dmg, e.g. https://downloads.puppet.com/mac/10.9/PC1/x86_64/puppet-agent-1.2.4-1.mavericks.dmg. So then beaker needed to know the codename to construct the URL. That was dumb, so we took the codename out of the package. |
kenyon
added a commit
to kenyon/beaker
that referenced
this pull request
Aug 27, 2024
This package is not needed and does nothing on the versions of Debian-family operating systems that we support (only non-EOL versions; see voxpupuli#1871, for other removal of EOL Debian-family code).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR isn't complete yet. I just saw the legacy code and wanted the PR as a reminder to get rid of it.