CI: Update CentOS7->CentOS9 #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMeier
approved these changes
Jul 23, 2024
ekohl
reviewed
Jul 23, 2024
| @@ -11,7 +11,7 @@ module HostPrebuiltSteps | |||
| SLEEPWAIT = 5 | |||
| TRIES = 5 | |||
| AMAZON2023_PACKAGES = %w[chrony] | |||
| RHEL8_PACKAGES = %w[chrony] | |||
| RHEL8_PACKAGES = %w[chrony iputils] # iputils provides ping. beaker assumes that's present | |||
There was a problem hiding this comment.
TIL: there's a ping method in beaker. I suspect we'd need to add that to Fedora and Amazon too.
This reminds me I should finish #1853 one day.
There was a problem hiding this comment.
I wasn't aware of it either :D
|
Thinking about it, adding the missing ping package is a Bugfix. I will pull that out into it's own PR tomorrow. |
Beaker assumes that the ping binary exists. in EL8 and EL9 that's provided by iputils. ``` [root@pe ~]# dnf whatprovides /usr/sbin/ping Fedora 40 - x86_64 23 MB/s | 56 MB 00:02 Fedora 40 openh264 (From Cisco) - x86_64 6.2 kB/s | 2.1 kB 00:00 Fedora 40 - x86_64 - Updates 19 MB/s | 32 MB 00:01 iputils-20240117-4.fc40.x86_64 : Network monitoring tools including ping Repo : @System Matched from: Filename : /usr/sbin/ping iputils-20240117-4.fc40.x86_64 : Network monitoring tools including ping Repo : fedora Matched from: Filename : /usr/sbin/ping [root@pe ~]# ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.