Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in csr_attributes.yaml filename #69

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

mdechiaro
Copy link
Contributor

@mdechiaro mdechiaro commented Feb 10, 2024

Closes: #68

@mdechiaro mdechiaro requested a review from a team as a code owner February 10, 2024 14:05
@mdechiaro mdechiaro changed the title Fix typo in csr_attrbitues.yaml filename Fix typo in csr_attributes.yaml filename Feb 10, 2024
@bastelfreak bastelfreak added the bug Something isn't working label Feb 10, 2024
@bastelfreak
Copy link
Member

@mdechiaro thanks for the PR! Can you please sign your commit with gpg or ssh?

@mdechiaro mdechiaro force-pushed the issue_8 branch 2 times, most recently from 215e3c6 to e268723 Compare February 10, 2024 15:02
@mdechiaro
Copy link
Contributor Author

@bastelfreak I signed this commit, and please take a look, thanks.

mdechiaro added a commit to mdechiaro/minikube-puppet-stack that referenced this pull request Feb 10, 2024
This branch is currently pending a PR before merging

voxpupuli/container-puppetserver#69
@bastelfreak
Copy link
Member

@mdechiaro the commit has Signed-off-by: Mark Dechiaro <[email protected]> but it's not signed with your ssh nor gpg key. To check:

$ git show e268723dd57be70fbe8f5b99345a83628633cd52 --show-signature
commit e268723dd57be70fbe8f5b99345a83628633cd52 (HEAD -> issue_8, pr1/issue_8)
Author: Mark Dechiaro <[email protected]>
Date:   Sat Feb 10 08:04:08 2024 -0600

    Fix typo in filename

    Closes: #68
    Signed-off-by: Mark Dechiaro <[email protected]>

diff --git a/puppetserver/docker-entrypoint.d/89-csr_attributes.rb b/puppetserver/docker-entrypoint.d/89-csr_attributes.rb
index 714b3ba..1a5419d 100755
--- a/puppetserver/docker-entrypoint.d/89-csr_attributes.rb
+++ b/puppetserver/docker-entrypoint.d/89-csr_attributes.rb
@@ -5,7 +5,7 @@ require 'yaml'

 begin
   csr_yaml = YAML.dump(JSON.load(ENV['CSR_ATTRIBUTES']))
-  File.open('/etc/puppetlabs/puppet/csr_attrbitues.yaml', 'w') do |file|
+  File.open('/etc/puppetlabs/puppet/csr_attributes.yaml', 'w') do |file|
     file.write(csr_yaml)
   end
 rescue => error

vs:

$ git show 64cce3363356540aa955335616d14693bcaec9b1 --show-signature
commit 64cce3363356540aa955335616d14693bcaec9b1 (codeowner)
gpg: Signature made Mi 11 Okt 2023 12:42:16 CEST
gpg:                using RSA key C10B6298A584A5632E254DA304D659E6BF1C4CC0
gpg: checking the trustdb
gpg: marginals needed: 3  completes needed: 1  trust model: pgp
gpg: depth: 0  valid:   3  signed:  10  trust: 0-, 0q, 0n, 0m, 0f, 3u
gpg: Note: third-party key signatures using the SHA1 algorithm are rejected
gpg: (use option "--allow-weak-key-signatures" to override)
gpg: depth: 1  valid:  10  signed:  19  trust: 2-, 0q, 0n, 0m, 8f, 0u
gpg: depth: 2  valid:  17  signed: 151  trust: 17-, 0q, 0n, 0m, 0f, 0u
gpg: next trustdb check due at 2024-04-10
gpg: Good signature from "Tim Meusel <[email protected]>" [ultimate]
gpg:                 aka "Tim Meusel <[email protected]>" [ultimate]
Author: Tim Meusel <[email protected]>
Date:   Wed Oct 11 12:42:16 2023 +0200

    Add CODEOWNERS

diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
new file mode 100644
index 0000000..61d2843
--- /dev/null
+++ b/.github/CODEOWNERS
@@ -0,0 +1,2 @@
+# No matter which file got changed, request a review from the main developers
+ * @voxpupuli/tools-containerimages

Closes: voxpupuli#68
Signed-off-by: Mark Dechiaro <[email protected]>
@mdechiaro
Copy link
Contributor Author

@bastelfreak thanks for letting me know my ssh key wasn't setup properly for signing. I fixed the issues and appreciate your help.

@bastelfreak bastelfreak merged commit aab6ba3 into voxpupuli:main Feb 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

csr_attributes.yaml not working due to typo in filename
2 participants