Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do multi stage build, remove package-lock.json, add usage for gitlab to README #14

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

rwaffen
Copy link
Member

@rwaffen rwaffen commented Sep 24, 2024

  • with npm install, package-lock.sjon is not needed anymore.
  • initially I though adding it was a common practice and good idea but 🤷

fixes: #11

…itlab to README


- with `npm install`, package-lock.sjon is not needed anymore.
- initially I though adding it was a common pracise and good idea but 🤷

fixes: #11
@rwaffen rwaffen requested a review from a team as a code owner September 24, 2024 09:26
@rwaffen rwaffen merged commit 5c7ac2f into main Sep 24, 2024
6 checks passed
@rwaffen rwaffen deleted the update_build branch September 24, 2024 09:47
@rwaffen rwaffen added the enhancement New feature or request label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do multi-stage build
2 participants