Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch runners to Ubuntu 24.04, use vagrant from hashicorp #57

Closed
wants to merge 8 commits into from

Conversation

daberkow
Copy link
Contributor

This is to help get voxpupuli/puppet-selinux#390 working. Selinux is low level enough we need vagrant with libvirt, but to test with AlmaLinux we need a newer version of Vagrant. AlmaLinux uses box v2 standard for vagrant thus requiring newer builds. We MAY be able to backport to 20.04 with some work if that is the preferred path. I also saw better perf, and less random build failures with 24.04 than I was on 20.04 vagrant.

bastelfreak and others added 8 commits June 3, 2024 10:52
This switches the default OS for CI jobs from ubuntu-latest (currently
22.04) to 24.04. Except for the beaker jobs, they still run with 20.04
becauser newer systems don't support EL7. We will change that later.
Update acceptance tests to run on 24.04
@daberkow
Copy link
Contributor Author

This is a continuation of #56, but with the acceptance tests running on ubuntu 24.04 not just the matrix setup

@daberkow daberkow changed the base branch from v2 to v3 June 20, 2024 14:43
@daberkow
Copy link
Contributor Author

@bastelfreak can I get a merge when you are ready :)

@bastelfreak bastelfreak changed the title Ubuntu 24.04 for libvirt update Switch runners to Ubuntu 24.04, use vagrant from hashicorp Jun 28, 2024
@bastelfreak
Copy link
Member

@evgeni Is the BSL a concern to you and should we use your PPA instead?

@evgeni
Copy link
Member

evgeni commented Jun 28, 2024

I would prefer using a free Vagrant version, at least as long as we can, yes.

@ekohl
Copy link
Member

ekohl commented Jun 28, 2024

@bastelfreak I feel we shouldn't accept BSL. I started a beaker-virt-lightning to use https://virt-lightning.org but it's too early to say if that'll work as a replacement

@evgeni
Copy link
Member

evgeni commented Jun 28, 2024

https://launchpad.net/~evgeni/+archive/ubuntu/vagrant/ exists, so as long as Vagrant is in Debian, I can produce Ubuntu builds without too much pain.

@bastelfreak
Copy link
Member

I want to point that a long long time ago, around a decade ago, Vox Pupuli, named puppet-community back then, had a dedicated server in colocation and was running beaker jobs for the communtiy and Puppetlabs Inc, via https://github.com/nibalizer/beaker-libvirt. Maybe it's time to revisit the plugin? When we want to speak to libvirt to start actual VMs, we don't need any abstraction between beaker and libvirt like Vagrant.

@evgeni
Copy link
Member

evgeni commented Jun 30, 2024

That's right. But having pre-built images that all behave somewhat identical and can be fetched from a sorta central index is a huge benefit.

@daberkow
Copy link
Contributor Author

daberkow commented Jul 8, 2024

What is the easiest path forward here to unblock work? Do we want to try to migrate to one of those other tools, do we want to use that RPM for now?

@bastelfreak
Copy link
Member

As a start, can you cherry-pick the Ubuntu 24.04 adjustments and provide them as a dedicated PR?

@daberkow daberkow mentioned this pull request Jul 12, 2024
@daberkow
Copy link
Contributor Author

Done! #59

@daberkow
Copy link
Contributor Author

But wont that have issues because 24 doesnt have vagrant included as a package! So v3 will be broken.

@bastelfreak
Copy link
Member

@daberkow could you rebase and update the branch to configure the PPA from https://launchpad.net/~evgeni/+archive/ubuntu/vagrant/ ?

@bastelfreak
Copy link
Member

@daberkow thanks for all the work. I rebased it and tested it in #60

@bastelfreak bastelfreak closed this Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants