Use shared workflows in modules #771
Conversation
| <%- @configs['beaker_fact_matrix'].each do |option, values| -%> | ||
| <%= option %>: | ||
| <%- values.each do |value| -%> | ||
| - "<%= value %>" | ||
| <%- end -%> | ||
| <%- end -%> | ||
| <%- if @configs['excludes'].any? -%> | ||
| exclude: | ||
| <%- @configs['excludes'].each do |exclude| -%> | ||
| <%- exclude.each do |key, value| -%> | ||
| <%= key == exclude.first.first ? '-' : ' ' %> <%= key %>: "<%= value %>" | ||
| <%- end -%> | ||
| <%- end -%> | ||
| <%- end -%> |
There was a problem hiding this comment.
TODO: there is no replacement for this yet. I'm thinking about pushing it into puppet_metadata. I started with voxpupuli/puppet_metadata#35.
ekohl
force-pushed
the
shared-workflows
branch
from
09f5258 to
f9e2026
Compare
ekohl
force-pushed
the
shared-workflows
branch
from
f9e2026 to
8b0227e
Compare
|
Status update: I'm feeling pretty confident in the CI workflow, both with just unit tests (verified in voxpupuli/puppet-example#15) and with beaker (verified in voxpupuli/puppet-trusted_ca#43). I haven't started on the release tests, but I'd like to merge voxpupuli/puppet-example#15 and iterate on the release. |
ekohl
force-pushed
the
shared-workflows
branch
2 times, most recently
from
6e1c40a to
16fa7e2
Compare
After a few small changes, that also works and https://forge.puppet.com/modules/puppet/example/0.2.1 is proof of that. See https://github.com/voxpupuli/puppet-example/actions/runs/1684914941 for the details. I'd consider gha-puppet almost ready, but IMHO we should decide on voxpupuli/gha-puppet#3 before tagging a 1.0.0 version. voxpupuli/gha-puppet#2 would also be nice, but less important. |
ekohl
force-pushed
the
shared-workflows
branch
from
16fa7e2 to
9e4e9ca
Compare
|
I've tagged version 1.0.0 of gha-puppet and believe this is ready. voxpupuli/puppet-example#20 reflects the last change. |
Shared workflows mean a lot less changes to modulesync. This leads to easier maintenance.
ekohl
force-pushed
the
shared-workflows
branch
from
9e4e9ca to
4dc9a81
Compare
Shared workflows mean a lot less changes to modulesync. This leads to easier maintenance.
For now this uses a repository in my own name (https://github.com/ekohl/gha-puppet) but I intend to move it over once I'm ok with it.