Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec/spec.opts: ensure the file is absent #903

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

bastelfreak
Copy link
Member

some of our modules have a legacy spec/spec.opts file:

https://github.com/voxpupuli/puppet-allknowingdns/blob/master/spec/spec.opts

We need to ensure that it's absent, otherwise CI won't pass:

https://github.com/voxpupuli/puppet-allknowingdns/actions/runs/9352662814/job/25741367385?pr=61

@bastelfreak bastelfreak self-assigned this Jun 3, 2024
@bastelfreak bastelfreak added the bug label Jun 3, 2024
@bastelfreak
Copy link
Member Author

I'm not sure what changed that this fails now and worked in the past, but I don't see a reason to have the spec/spec.opts in some modules.

@bastelfreak
Copy link
Member Author

$ find puppet-*/spec/spec.opts -ls
 11937921      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Aug 13  2021 puppet-allknowingdns/spec/spec.opts
 10894449      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Dez  2  2021 puppet-augeasproviders_apache/spec/spec.opts
 10893987      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Dez  2  2021 puppet-augeasproviders_base/spec/spec.opts
 10893142      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Dez  2  2021 puppet-augeasproviders_grub/spec/spec.opts
 10893513      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Dez  2  2021 puppet-augeasproviders_mounttab/spec/spec.opts
 10894289      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Dez  2  2021 puppet-augeasproviders_nagios/spec/spec.opts
 10892965      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Dez  2  2021 puppet-augeasproviders_pam/spec/spec.opts
 10893664      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Dez  2  2021 puppet-augeasproviders_postgresql/spec/spec.opts
 10894139      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Dez  2  2021 puppet-augeasproviders_puppet/spec/spec.opts
  9046291      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Dez  2  2021 puppet-augeasproviders/spec/spec.opts
 10892812      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Dez  2  2021 puppet-augeasproviders_sysctl/spec/spec.opts
 10893828      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Dez  2  2021 puppet-augeasproviders_syslog/spec/spec.opts
  8786746      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Jul 19  2021 puppet-bird/spec/spec.opts
      754      0 -rw-r--r--   1 bastelfreak bastelfreak        0 Aug 13  2021 puppet-confluence/spec/spec.opts
      925      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Aug 13  2021 puppet-corosync/spec/spec.opts
     1704      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Aug 13  2021 puppet-dropbear/spec/spec.opts
     2503      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Aug 13  2021 puppet-fail2ban/spec/spec.opts
     5204      4 -rw-r--r--   1 bastelfreak bastelfreak       43 Aug 13  2021 puppet-keepalived/spec/spec.opts
   664612      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Aug 13  2021 puppet-metche/spec/spec.opts
 12590219      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Aug  2  2021 puppet-openvmtools/spec/spec.opts
  2231703      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Aug 13  2021 puppet-pbuilder/spec/spec.opts
  2231930      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Aug 13  2021 puppet-posix_acl/spec/spec.opts
  2236288      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Aug 13  2021 puppet-python/spec/spec.opts
  2359516      4 -rw-r--r--   1 bastelfreak bastelfreak       43 Aug 13  2021 puppet-redis/spec/spec.opts
  2360769      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Aug 13  2021 puppet-snmp/spec/spec.opts
 12322227      4 -rw-r--r--   1 bastelfreak bastelfreak       46 Apr 12 13:23 puppet-swap_file/spec/spec.opts
 11536404      4 -rw-r--r--   1 bastelfreak bastelfreak       46 Jul 14  2021 puppet-telegraf/spec/spec.opts
  2361945      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Aug 13  2021 puppet-trusted_ca/spec/spec.opts
 11144706      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Okt 20  2023 puppet-wildfly/spec/spec.opts
  2363516      4 -rw-r--r--   1 bastelfreak bastelfreak       47 Aug 13  2021 puppet-zypprepo/spec/spec.opts

@bastelfreak bastelfreak merged commit 932b789 into voxpupuli:master Jun 3, 2024
4 checks passed
@bastelfreak bastelfreak deleted the foo branch June 3, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants