Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop upstart support, refactor unit tests #36

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Drop upstart support, refactor unit tests #36

merged 1 commit into from
Nov 25, 2024

Conversation

jay7x
Copy link
Member

@jay7x jay7x commented Nov 25, 2024

Modernize unit tests:

  • Fix rubocop todo item
  • Wrap them with on_supported_os.each (that fixed missing networking.ip issue also)
  • Change formatting in a few places (to reduce line length or to reduce amount of lines)
  • Drop upstart support (it was removed in Ubuntu 16, which is EOLed while ago)

@jay7x jay7x changed the title Refactor unit tests Drop upstart support, refractor unit tests Nov 25, 2024
@jay7x jay7x changed the title Drop upstart support, refractor unit tests Drop upstart support, refactor unit tests Nov 25, 2024
@jay7x
Copy link
Member Author

jay7x commented Nov 25, 2024

Better to view changes with whitespace difference disabled FYI.

This was referenced Nov 25, 2024
Merged
Merged
@jay7x jay7x marked this pull request as ready for review November 25, 2024 05:36
@jay7x jay7x merged commit 5cf5408 into voxpupuli:master Nov 25, 2024
13 checks passed
@jay7x jay7x deleted the fix_tests branch November 25, 2024 09:37
@jay7x jay7x added the enhancement New feature or request label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jay7x @bastelfreak