Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Ubuntu 20.04 and Bareos 20 signing key #79

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Added Ubuntu 20.04 and Bareos 20 signing key #79

merged 1 commit into from
Nov 26, 2021

Conversation

hugendudel
Copy link
Contributor

@hugendudel hugendudel commented Apr 15, 2021 •
edited
Loading

Added Ubuntu 20.04 and Bareos 20 signing key

Hey folks,

  • I have added Ubuntu 20.04 to the supported operating systems
  • I have added the Bareos 20 release signing key

The logic with the key selection could be revised if necessary?

fixes [#85 #80]

@hugendudel
Copy link
Contributor Author

Hi folks,

is there any news on this? Are you interested in the feature and would you like to have it? Are there any changes to be made?

I am looking forward to your feedback!

Greetings
Harm

smortex
smortex reviewed Oct 13, 2021
View reviewed changes
manifests/repository.pp Outdated Show resolved Hide resolved
smortex
smortex reviewed Oct 15, 2021
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine!

Only one minor suggestion

manifests/repository.pp Outdated Show resolved Hide resolved
@hugendudel
added Ubuntu 20.04 to supported operating systems and the release key…
d7fdcaf 
… for version 20, also set version 20 as default

changed release variable to enum and only added supported versions(>=18.2) https://download.bareos.com/bareos/release/
@hugendudel
Copy link
Contributor Author

Hello @smortex,
please let me know if this meets your expectations.
Greetings
Harm

smortex
smortex approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks okay. Since I am not a user of this module I let another person proof-read and merge this.

@matejzero
Copy link
Contributor

matejzero commented Oct 21, 2021 •
edited
Loading

I'm a user of this module and this fix looks legit. I didn't check the GPG key fingerprint, but other than that, it looks OK.

Would love to have this merged so I can deploy it to my environment via Puppetfile.

@smortex
Copy link
Member

smortex commented Oct 21, 2021

Would love to have this merged so I can deploy it to my environment via Puppetfile.

Using r10k? You can test with:

mod 'puppet-bareos', git: 'https://github.com/hugendudel/puppet-bareos.git', branch: 'ubuntu_20_04'

@hugendudel
Copy link
Contributor Author

Hi folks, any news on the changes or suggestions?

@smortex smortex merged commit 926bda8 into voxpupuli:master Nov 26, 2021
@root-expert
Copy link
Member

Ubuntu 20.04 was never added to the metadata.json in this PR. @hugendudel are you interested in opening a new PR?

@hugendudel
Copy link
Contributor Author

Sure, I will open a PR!

@hugendudel hugendudel mentioned this pull request Feb 14, 2022
Merged
@hugendudel
Copy link
Contributor Author

et voilà #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hugendudel @matejzero @smortex @root-expert