Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.0 #67

Merged
merged 4 commits into from
May 14, 2020
Merged

Release 2.0.0 #67

merged 4 commits into from
May 14, 2020

Conversation

dhoppe
Copy link
Member

@dhoppe dhoppe commented Apr 29, 2020

Fixes #65

@ghoneycutt
Copy link
Member

Please merge #53 before doing the release. This way 2.0.0 starts out refactored.

@dhoppe
Copy link
Member Author

dhoppe commented Apr 30, 2020

Years ago you wanted to do this kind of refactoring with my dhoppe/fail2ban module. Guess what, the install.pp, config.pp and service.pp manifests still exist. I did not like it then and I still do not like it now.

I had a discussion with @ekohl about this yesterday and I am still not convinced. I like the division into install.pp, config.pp and service.pp, because it results in small and clear files. Also I do not have to care about notify or require.

In the last days I have invested a lot of time to standardize this module to some extent. There is still a lot of work to do for Caddy 2 and we can talk about parameters like manage_user, manage_group, manage_install and manage_service, but I will not merge this pull request.

@dhoppe dhoppe requested a review from bastelfreak May 5, 2020 08:48
bastelfreak
bastelfreak previously approved these changes May 5, 2020
@dhoppe dhoppe merged commit 73e0c52 into voxpupuli:master May 14, 2020
@dhoppe dhoppe deleted the release_2.0.0 branch May 14, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a final release for Caddy 1
3 participants