Remove cache_data helper methods

These do not appear to be needed anymore. Removing this simplifies the
code.

.gitignore

@@ -18,4 +18,3 @@ Puppetfile.lock
 .*.sw?
 .yardoc/
 Guardfile
-spec/fixtures/tmpdir/

.sync.yml

@@ -1,8 +1,3 @@
 ---
 .travis.yml:
   secure: "IkrfAnec7ovZLMvhvXt8ZihyYdAJTC/nm7KDm4u2G/uD2NGaMdHNOAenkwIwC1vfCzHKcgC5u/lAYFrYvHpQpJW0kHLKnk1SpndfWX9kd5SlDDzEP5mJGjMZeTY6H9sV5fsB6Pt7l/sw5ACL/0bFDl0mYBnVhGv6UxZZ5xMQIUw="
-spec/spec_helper.rb:
-  spec_overrides: "require 'spec_helper_methods'"
-.gitignore:
-  paths:
-    - spec/fixtures/tmpdir/

spec/functions/extlib/cache_data_spec.rb

@@ -4,7 +4,6 @@
   let(:initial_data) { 'original_password' }
   let(:data_name) { 'mysql_password' }
   let(:namespace) { 'data_cache' }
-  let(:vardir)    { "#{FIXTURES_PATH}/tmpdir" }
 
   it { expect(subject).not_to eq(nil) }
   it { is_expected.not_to eq(nil) }
@@ -13,17 +12,6 @@
   it { is_expected.to run.with_params('', 'mysql_password', initial_data).and_raise_error(ArgumentError) }
 
   describe 'data caching' do
-    before do
-      # Fool rspec-puppet into creating a consistent vardir for these tests!
-      allow(Dir).to receive(:mktmpdir).and_return("#{FIXTURES_PATH}/tmpdir")
-      # Stop rspec-puppet from blowing away the vardir between each example.  Is unstubbed in the after block.
-      allow(FileUtils).to receive(:rm_rf).with(vardir).and_return(true)
-    end
-    after do
-      # Since rspec-puppet won't be removing the vardir, we'd better do that ourselves.
-      FileUtils.rm_rf(vardir) if File.directory?(vardir)
-    end
-
     context 'when not in cache' do
       it 'returns supplied data' do
         is_expected.to run.with_params(namespace, data_name, initial_data).and_return(initial_data)

spec/spec_helper.rb

@@ -16,5 +16,3 @@
     end
   end
 end
-
-require 'spec_helper_methods'