Enable gpgcheck for YUM RPM based Distributions #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traylenator
changed the title
Currently the yum repositories for gitlab runner installations are preset with a hardcoded `gpgcheck => 0`. Introduce new parameters: * `pacakage_gpgcheck` defaulting to true that sets `gpgcheck => 1` for yum based distributions. * `package_keysource` defaulting to current location of the gpg key for gitlab package. By default gpgchecking will now be enabled for RPM/YUM based distributions which was not the case before. See: * Package signature https://docs.gitlab.com/runner/install/linux-repository.html#rpm-based-distributions * Repository signature https://packages.gitlab.com/app/gitlab/gitlab-ce/gpg
bastelfreak
reviewed
Nov 22, 2024
| @@ -42,13 +44,14 @@ | |||
| $source_base_url = "${repo_base_url}/runner/${package_name}/el/\$releasever/SRPMS" | |||
| } | |||
|
|
|||
| $_gpgkeys = [$repo_keysource,$package_keysource].delete_undef_values.join(' ') | |||
There was a problem hiding this comment.
oh I didn't know that a repo config allows multiple keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Currently the yum repositories for gitlab runner installations are preset with a hardcoded
gpgcheck => 0.Introduce new parameters:
pacakage_gpgcheckdefaulting to true that setsgpgcheck => 1for yum based distributions.package_keysourcedefaulting to current location of the gpg key for gitlab package.By default gpgchecking will now be enabled for RPM/YUM based distributions which was not the case before.
See: