Debian: Configure correct shell for hdm user

.gitignore

@@ -1,3 +1,4 @@
+.vendor/
 .git/
 .*.sw[op]
 .metadata

Gemfile

@@ -1,7 +1,7 @@
 source ENV['GEM_SOURCE'] || "https://rubygems.org"
 
 group :test do
-  gem 'voxpupuli-test', '~> 2.5',   :require => false
+  gem 'voxpupuli-test', '~> 5',     :require => false
   gem 'coveralls',                  :require => false
   gem 'simplecov-console',          :require => false
   gem 'puppet_metadata', '~> 1.0',  :require => false

spec/acceptance/docker_spec.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require 'spec_helper_acceptance'
+
+describe 'hdm' do
+  context 'with docker' do
+    it_behaves_like 'an idempotent resource' do
+      let(:manifest) do
+        <<-PUPPET
+        class { 'hdm':
+          method => 'docker',
+        }
+        PUPPET
+      end
+    end
+    describe service('docker-hdm') do
+      it { is_expected.to be_enabled }
+      it { is_expected.to be_running }
+    end
+
+    # rubocop:disable RSpec/RepeatedExampleGroupBody
+    describe command('journalctl --unit docker-hdm --lines 500 --no-pager') do
+      its(:exit_status) { is_expected.to eq 0 }
+    end
+
+    describe command('docker container ls --all') do
+      its(:exit_status) { is_expected.to eq 0 }
+    end
+
+    describe command('docker image ls --all') do
+      its(:exit_status) { is_expected.to eq 0 }
+    end
+    # rubocop:enable RSpec/RepeatedExampleGroupBody
+  end
+end

spec/setup_acceptance_node.pp

@@ -0,0 +1,6 @@
+# Needed for os.distro.codebase fact
+if $facts['os']['name'] == 'Ubuntu' and $facts['os']['release']['full'] == '18.04' and versioncmp($facts['puppetversion'], '7') <= 0 {
+  package{'lsb-release':
+    ensure => present,
+  }
+}

spec/spec_helper.rb

@@ -1,17 +1,17 @@
+# frozen_string_literal: true
+
 # Managed by modulesync - DO NOT EDIT
 # https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
 
 # puppetlabs_spec_helper will set up coverage if the env variable is set.
 # We want to do this if lib exists and it hasn't been explicitly set.
-ENV['COVERAGE'] ||= 'yes' if Dir.exist?(File.expand_path('../../lib', __FILE__))
+ENV['COVERAGE'] ||= 'yes' if Dir.exist?(File.expand_path('../lib', __dir__))
 
 require 'voxpupuli/test/spec_helper'
 
 if File.exist?(File.join(__dir__, 'default_module_facts.yml'))
   facts = YAML.safe_load(File.read(File.join(__dir__, 'default_module_facts.yml')))
-  if facts
-    facts.each do |name, value|
-      add_custom_fact name.to_sym, value
-    end
+  facts&.each do |name, value|
+    add_custom_fact name.to_sym, value
   end
 end

spec/spec_helper_acceptance.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+# Managed by modulesync - DO NOT EDIT
+# https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
+
+require 'voxpupuli/acceptance/spec_helper_acceptance'
+
+configure_beaker
+
+Dir['./spec/support/acceptance/**/*.rb'].sort.each { |f| require f }