fix #368 Add manage_package param to do not manage removed icingaweb2…

…-module-monitoring package on Debian and Ubuntu

README.md

@@ -27,6 +27,11 @@ This module can manage all configurations files of Icinga Web 2 and import an in
 manage all official [modules](https://www.icinga.com/products/icinga-web-2-modules/) as well as modules developed by the
 community.
 
+### What's new in version 3.9.1
+
+The Icinga team removed package icingaweb2-module-monitoring (only on Debian/Ubuntu) for Icinga Web 2 >= 2.12.0. For now
+we add an parameter `manage_package` (set to `true` bye default) to do not managed the missing transition package.
+
 ### What's new in version 3.0.0
 
 * The current version now uses the `icinga::repos` class from the new module `icinga` for the configuration of

manifests/globals.pp

@@ -51,6 +51,12 @@
 # @param pgsql_idoreports_sla_percent
 #   Location of the get_sla_ok_percent database extension for PostgreSQL.
 #
+# @param mysql_x509_schema
+#   Location of the x509 database schema for MySQL/MariaDB.
+#
+# @param pgsql_x509_schema
+#   Location of the x509 database schema for PostgreSQL.
+#
 # @param gettext_package_name
 #   Package name `gettext` tool belongs to.
 #

manifests/module/monitoring.pp

@@ -10,6 +10,11 @@
 #   Custom variables in Icinga 2 may contain sensible information. Set patterns for custom variables
 #   that should be hidden in the web interface.
 #
+# @param manage_package
+#   Set to `false` as Fix for Icinga Web >= 2.12.0 to do not manage the removed package
+#   `icingaweb2-module-monitoring` (only Debian/Ubuntu).
+#   See issue #368 (https://github.com/Icinga/puppet-icingaweb2/issues/368).
+#
 # @param ido_type
 #   Type of your IDO database. Either `mysql` or `pgsql`.
 #
@@ -91,6 +96,7 @@
   Enum['absent', 'present']      $ensure               = 'present',
   Variant[String, Array[String]] $protected_customvars = ['*pw*', '*pass*', 'community'],
   Enum['mysql', 'pgsql']         $ido_type             = 'mysql',
+  Boolean                        $manage_package       = true,
   Optional[Stdlib::Host]         $ido_host             = undef,
   Optional[Stdlib::Port]         $ido_port             = undef,
   Optional[String]               $ido_db_name          = undef,
@@ -116,8 +122,13 @@
 
   case $facts['os']['family'] {
     'Debian': {
-      $install_method = 'package'
-      $package_name   = 'icingaweb2-module-monitoring'
+      if $manage_package {
+        $install_method = 'package'
+        $package_name   = 'icingaweb2-module-monitoring'
+      } else {
+        $install_method = 'none'
+        $package_name   = undef
+      }
     }
     default: {
       $install_method = 'none'

spec/classes/monitoring_spec.rb

@@ -133,6 +133,23 @@
         }
       end
 
+      context "#{os} with manage_package 'false'" do
+        let(:params) do
+          { ido_type: 'mysql',
+            ido_host: 'localhost',
+            ido_db_name: 'icinga2',
+            ido_db_username: 'icinga2',
+            ido_db_password: 'icinga2',
+            manage_package: false }
+        end
+
+        it {
+          is_expected.to contain_icingaweb2__module('monitoring')
+            .with_install_method('none')
+            .with_module_dir('/usr/share/icingaweb2/modules/monitoring')
+        }
+      end
+
       context "#{os} with invalid ido_type" do
         let(:params) { { ido_type: 'foobar' } }