Support for comments and more types

[elfranne]

Pull Request (PR) description

Add support for comments (#5) and the types from the man page.

counters skbinfo markmask options are not implemented, they are boolean options. If anyone has any advice on how to implement that cleanly ...

example with using hiera data for bitmap:port:

data::from::hiera::ports:
  - 5005
  - 5006
  - 5007
  - 5008
  - 5009
  - 5010
  - 5023
  - 5027
  - 5028
  - 5031

  ipset::set { 'port-server1':
    set     => lookup('data::from::hiera::ports'),
    type    => 'bitmap:port',
    options => {
      range => '5000-6000',
    },
  }

If you want to limit to udp:

  ipset::set { 'port-server2':
    set     => lookup('data::from::hiera::ports').map |$value| { "udp:${value}" },
    type    => 'bitmap:port',
    options => {
      range => '5000-6000',
    },
  }

This was primarily implemented to be able to create non consecutive port lists as iptables only support a maximum of 15 ports with the --multiports and the XT_MULTI_PORTS compile setting source

[bastelfreak]

can you make this a bit more strict? Are empty strings okay or should we enforce a minimal length?

[elfranne]

Optional[range]    => Pattern[/^6553[0-5]|655[0-2][0-9]|65[0-4][0-9]{2}|6[0-4][0-9]{3}-6553[0-5]|655[0-2][0-9]|65[0-4][0-9]{2}|6[0-4][0-9]{3}$/],
Optional[comment]  => Pattern[/^(.*").*$/],

Port regex blatantly stolen from StackOverflow

According do documentation only " is an illegal character in the comment.

[bastelfreak]

thanks for the PR. can you please add some unit tests as well?