Use a template string for the crictl download URL #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR replaces the
download_url
parameter of thecrictl
class with a new parameter calleddownload_url_template
. This parameter uses template variables and is rendered using thek8s::format_url
function, similar to how other download URLs are handled in this module.The k8s::format_url function auto-detects the CPU architecture, so the arch parameter is no longer required. I am therefore removing it from the class.
NOTE: This is a breaking change for users that use the
download_url
parameter. Should this be noted somewhere?This Pull Request (PR) fixes the following issues
Without templating, it is cumbersome to override the download URL. The user has to handle the version and arch themselves. It is also inconsistent with other parts of the module that use templating for download URLs.