Some updates to be able to create multiple mirror services with specific configurations

[idrissneumann]

Pull Request (PR) description

We'd like to be able to easily create multiple mirror services from hieradata like that:

$mirrors.each |$title, $mirror| {
      kafka::mirror { $title:
        consumer_config          => $mirror['consumer_config'],
        ........
      }
}

And we'd like to be able to easily notify all mirror services like that:

java_ks { "......:truststore":
   ensure       => latest,
   certificate  => "${properties_dir}/.....pem",
   target       => "${properties_dir}/.....jks",
   password     => "........",
   path         => ["${jdk_path}/jre/bin", "/bin", "/usr/bin"],
   trustcacerts => true
} ~> Kafka::Mirror <| |>

And we'd like to be able to change the path of /etc/systemd/system.

This Pull Request (PR) fixes the following issues

[bastelfreak]

Hi @idrissneumann, thanks for the work. Please don't delete the tests, they need to be restored and restructured so they work with the defined resources.

[idrissneumann]

@bastelfreak Thanks for reviewing. I'm not used to use rspec, so I don't know too much how to convert a class spec to a defined resource spec (we're using real puppet agents and server with docker in our own CI and a pre-compilation step using octocatalog). Anyway, I'll take some time to learn that and to rewrite those specs one day ^^

[vox-pupuli-tasks]

Dear @idrissneumann, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

[vox-pupuli-tasks]

Dear @idrissneumann, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

[TheMeier]

Looks abandoned to me, I would close it