Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the Certbot Gandi plugin #295
base: master
Are you sure you want to change the base?
Add support for the Certbot Gandi plugin #295
Changes from 10 commits
de30daa
bf81b49
863985a
471c64e
37200dc
f062f57
2d89536
b51de96
d62ea76
09ba2f7
e010968
9323fb2
0287c8b
b2fe5ce
6c82c1a
ed0cfca
f8457b7
17c1b61
47824f6
ef0d4f5
a513b57
1e65a10
3996f08
cfdbfc5
136b8d3
8b98489
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an unused parameter. Shouldn't it be passed to the
package
resource?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A better way is to test for the error:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too it's better to compile and test for a specific error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this one, the module won't work with an empty api_key and I don't know how to handle the error:
it { is_expected.to compile.and_raise_error(%r{/expects a value for parameter 'api_key'/}) }
is not correct?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
/
is redundant. In Ruby you can define a regex as/my regex/
or%r{my regex}
but%r{/my regex/}
means you expect/
in the output. This is useful if you want to test/var/lib is empty
is in the error. Compare%r{/var/lib is empty}
to/\/var\/lib is empty/
.