Convert module to PDK and cleanup tests #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear @h-haaks, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
|
Dear @h-haaks, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
added 5 commits
July 4, 2022 23:42
The logstash-plugin command changed to require a --installed option and it has to be run from logstash home directory.
Merged
|
I'll close this pull request in favor of #418 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been using some days now to try to fix all testing issues in the module.
To do this I started out by converting the module to PDK 1.18.1.
I have done my best to map existing setup, but there is some major changes.
I had to skip some acceptance tests in the plugin class for versions >= 6.7 because there have been a change
in the logstash-plugin command.
This command changed in two ways as I can see.
1: it now has to be run from the logstash homedir
2: new option --installed is needed to list only installed plugins
To solve this we either have to drop support for versions < 6.7, or implement a fact that hold the installed logstash version.
Please let me know what you think of my changes..
I really need this module back on track with java 11+ and logstash 7.
Ref #401