Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add krb5 client keytab var #411

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

Valantin
Copy link
Contributor

Pull Request (PR) description

Add shell var to manage krb5_client_ktname and configure export variable on Debian Family OS

This Pull Request (PR) fixes the following issues

configure krb5 keytab for Debian family OS

@bastelfreak bastelfreak added the enhancement New feature or request label Mar 25, 2024
@@ -32,6 +32,7 @@
Optional[Stdlib::Absolutepath] $ldapi_socket_path = undef,
Optional[Boolean] $register_slp = undef,
Optional[Stdlib::Absolutepath] $krb5_keytab_file = undef,
Optional[Stdlib::Absolutepath] $krb5_client_keytab_file = undef,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a puppet-strings style documentation at the top (like it happened for manage_policy_rc_d)

@bastelfreak
Copy link
Member

thanks for the PR, can you maybe add a unit test to verify this works as expected?

@Valantin
Copy link
Contributor Author

Yes, tomorrow try to work on it

@Valantin Valantin force-pushed the add-krb5_var branch 3 times, most recently from 7a64a3a to bbf47ea Compare March 26, 2024 10:47
Configure shell variable for kerberos configuration on debian family system
@bastelfreak bastelfreak merged commit c630df5 into voxpupuli:master Mar 26, 2024
30 checks passed
@Valantin Valantin deleted the add-krb5_var branch March 29, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants