Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen restrictive regex on syncrepl keepalive #421

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Loosen restrictive regex on syncrepl keepalive #421

merged 1 commit into from
Jun 2, 2024

Conversation

gcoxmoz
Copy link
Contributor

@gcoxmoz gcoxmoz commented May 8, 2024

Pull Request (PR) description

https://www.openldap.org/doc/admin25/slapdconfig.html - "The keepalive parameter sets the values of idle, probes, and interval used to check whether a socket is alive; idle is the number of seconds a connection needs to remain idle before TCP starts sending keepalive probes; probes is the maximum number of keepalive probes TCP should send before dropping the connection; interval is interval in seconds between individual keepalive probes."

The keepalive parameter from #412 is Pattern['\A\d{2}:\d{2}:\d{2}\z'] - those {2} items are overly restrictive: a lax idle config may wish for over 99 seconds before starting probes, an aggressive probe config may want to recycle connections at, say, 3 misses. So, this loosens the restriction to Pattern['\A\d+:\d+:\d+\z'] and gives back looser/tighter tuning.

This Pull Request (PR) fixes the following issues

@gcoxmoz
Copy link
Contributor Author

gcoxmoz commented May 8, 2024

Failing tests look specific to almalinux and unrelated to the PR.

@TheMeier
Copy link
Contributor

TheMeier commented May 8, 2024

Yes this is unrelated, but it certainly should be fixed before merging anything :(

2024-05-08T17:21:18.9408003Z �[00;00m�[00;33m  Error: Execution of '/usr/bin/dnf -d 0 -e 1 -y install openldap-servers' returned 1: Error: 

@gcoxmoz
Copy link
Contributor Author

gcoxmoz commented May 8, 2024

https://bugzilla.redhat.com/show_bug.cgi?id=2278783 - So the runner is presumably a 9.4 and epel is providing a busted openldap-servers package until epel gets the new package.

@TheMeier TheMeier added enhancement New feature or request and removed tests-fail labels Jun 2, 2024
@TheMeier TheMeier merged commit f5884f2 into voxpupuli:master Jun 2, 2024
30 checks passed
@gcoxmoz gcoxmoz deleted the syncrepl-keepalive branch June 2, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants