Loosen restrictive regex on syncrepl keepalive #421
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
https://www.openldap.org/doc/admin25/slapdconfig.html - "The keepalive parameter sets the values of idle, probes, and interval used to check whether a socket is alive; idle is the number of seconds a connection needs to remain idle before TCP starts sending keepalive probes; probes is the maximum number of keepalive probes TCP should send before dropping the connection; interval is interval in seconds between individual keepalive probes."
The keepalive parameter from #412 is
Pattern['\A\d{2}:\d{2}:\d{2}\z']
- those{2}
items are overly restrictive: a laxidle
config may wish for over 99 seconds before starting probes, an aggressiveprobe
config may want to recycle connections at, say, 3 misses. So, this loosens the restriction toPattern['\A\d+:\d+:\d+\z']
and gives back looser/tighter tuning.This Pull Request (PR) fixes the following issues