Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.0.0 #219

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Release 4.0.0 #219

merged 1 commit into from
Jul 19, 2024

Conversation

bastelfreak
Copy link
Member

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak bastelfreak self-assigned this Jul 18, 2024
ekohl
ekohl requested changes Jul 18, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and I'm fairly sure #190 would be covered by the acceptance tests now. Since we're doing a major release, I'd suggest to include it now.

@bastelfreak
Copy link
Member Author

@ekohl updated it

@ekohl
Copy link
Member

ekohl commented Jul 18, 2024

As noted on IRC: should we upgrade des3 while we're making a major version:

puppet-openssl/lib/puppet/provider/ssl_pkey/openssl.rb

Line 28 in cac0733

cipher = OpenSSL::Cipher.new('des3')

@bastelfreak
Copy link
Member Author

bastelfreak commented Jul 18, 2024 •
edited
Loading

switch from des3 to aes:

@bastelfreak bastelfreak force-pushed the rel400 branch 2 times, most recently from ee12145 to cabd429 Compare July 18, 2024 20:15
@ekohl
Copy link
Member

ekohl commented Jul 18, 2024

CI is still running, but I'd expect #167 to pass.

@bastelfreak bastelfreak force-pushed the rel400 branch 2 times, most recently from 4d0180d to 28163c2 Compare July 19, 2024 09:14
ekohl
ekohl approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Down to 1 open PR after this.

@bastelfreak bastelfreak merged commit e82a189 into voxpupuli:master Jul 19, 2024
28 checks passed
@bastelfreak bastelfreak deleted the rel400 branch July 19, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees

@bastelfreak bastelfreak

Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastelfreak @ekohl