Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blackbox_exporter:modules leaking sensitive info so adding no diff #615

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

blackbox_exporter:modules leaking sensitive info so adding no diff #615

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e06217b
leaking sensitive info so adding no diff
mvnarsing Apr 12, 2022
b566518
fixing indentation
mvnarsing Apr 12, 2022
597c534
fixing indentation
mvnarsing Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions manifests/blackbox_exporter.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,13 @@
$options = "--config.file=${config_file} ${extra_options}"

file { $config_file:
ensure => file,
owner => 'root',
group => $group,
mode => $config_mode,
content => template('prometheus/blackbox_exporter.yaml.erb'),
notify => $notify_service,
ensure => file,
owner => 'root',
group => $group,
mode => $config_mode,
show_diff => false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO Sensitive support would be better. Or at least make show_diff configurable here. But I don't use this module, so 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Sensitive would be better also the erb should be changed to epp

content => template('prometheus/blackbox_exporter.yaml.erb'),
notify => $notify_service,
}

prometheus::daemon { $service_name:
Expand Down