PS-10287 Improve support for custom my.cnf #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Nov 17, 2020
| Facter.add(:proxysql_mycnf_file_name) do | ||
| setcode do | ||
| if File.exist? '/root/.proxysql_mycnf_file_name' | ||
| Facter::Core::Execution.execute('cat /root/.proxysql_mycnf_file_name') |
There was a problem hiding this comment.
is cat the correct way to open this? We can also use pure ruby to read it in. Can we assume it's safe to cat the file and that it doesn't contain any sensitive data?
There was a problem hiding this comment.
i just adopted the Open PR from March 2020 ...
The file contains the value of :mycnf_file_name to use it in ruby code instead of hard coded /root/.my.cnf
(For my usecase i have already a /root/.my.cnf for mysql and so i need another file storing Proxysql admin creds)
jadestorm
pushed a commit
to ncstate-daniel/puppet-proxysql
that referenced
this pull request
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I adapted the Code from #140 and did a modification for resolving dependency on fresh installation.