Add savedsearches.conf to managed files #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add savedsearches.conf to files we can manage
Add savedsearches.conf to files we can manage
Add savedsearches.conf to files we can manage
Add savedsearches.conf to files we can manage
Add savedsearches.conf to files we can manage
Add savedsearches.conf to files we can manage
Add savedsearches.conf to files we can manage
Add savedsearches.conf to files we can manage
Make addons recognize a version string
bastelfreak
reviewed
Oct 9, 2019
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "puppet-splunk", | |||
| "version": "7.3.1-rc0", | |||
| "version": "7.3.2", | |||
There was a problem hiding this comment.
Please don't update the version. We will handle this during the release process
|
Hi @bsg-sfrazer, thanks for the PR. Can you please rebase against our master branch and squash the commits into one? Can you also add tests for the new parameters? |
|
Hi Tim,
Sorry about the release version, we needed it so librarian would update.
We actually stopped using this functionality fairly quickly. Turns out: if a user saves a search through the web interface, this will overwrite it
I’ve been working on a way to distribute the searches through Splunk Apps using this module, but I’ve run into a versioning issue: if you supply an app tarball it will install fine but there’s no way to get it to update the tarball should anything change.
I’m playing with adding a versioning string to the Splunk::addons class
…________________________________
From: Tim Meusel <[email protected]>
Sent: Wednesday, October 9, 2019 4:21:37 PM
To: voxpupuli/puppet-splunk <[email protected]>
Cc: Scott Frazer <[email protected]>; Mention <[email protected]>
Subject: Re: [voxpupuli/puppet-splunk] Add savedsearches.conf to managed files (#245)
Hi @bsg-sfrazer<https://github.com/bsg-sfrazer>, thanks for the PR. Can you please rebase against our master branch and squash the commits into one? Can you also add tests for the new parameters?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#245?email_source=notifications&email_token=ALGEDRCULWV4XINGMWV7YC3QNZDODA5CNFSM4IFGFTG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAZOBYY#issuecomment-540205283>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALGEDRGSHVWHLO2AYHQINFTQNZDODANCNFSM4IFGFTGQ>.
|
Make installer create the versioning string
…verwritable in the future
Allow archiver to overwrite files, ensure the written files will be o…
fix permissions on manifest
fix permissions on manifest
fix permissions on manifest
|
Dear @bsg-sfrazer, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
1 similar comment
|
Dear @bsg-sfrazer, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Adds the "savedsearches.conf" file to the list of managable files
This Pull Request (PR) fixes the following issues
Fixes #244