Debian: Add support for Splunk 9.4 and newer

[muncjack]

this change is to change the file name of the debian packer after version 9.4.0
it was: -linux-2.6-
it needs to be: -linux-

Pull Request (PR) description

the is a problem when trying to install splunk 9.4.0 in ubuntu hosts due to package file name change

This Pull Request (PR) fixes the following issues

Fixes #392

[maxadamo]

Looks Good to me.
I checked the RPM and it is still using the same old name. This change is required only for DEB packages.

[vchepkov]

I don't think this is specific for Debian, for example, rpm is also changed:

"https://download.splunk.com/products/splunk/releases/9.4.0/linux/splunk-9.4.0-6b4ebe426ca6.x86_64.rpm"

[bastelfreak]

Hi, thanks for the PR!

We've some acceptance tests in https://github.com/voxpupuli/puppet-splunk/tree/master/spec/acceptance . Could you extend them to also run on Splunk 9.4?

[maxadamo]

I don't think this is specific for Debian, for example, rpm is also changed:

"https://download.splunk.com/products/splunk/releases/9.4.0/linux/splunk-9.4.0-6b4ebe426ca6.x86_64.rpm"

@vchepkov I don't think so.
I quickly checked with puppet-debugger:

1:>> $version = '9.4.0'
 => "9.4.0"
2:>> $linux_prefix = (versioncmp($version, '9.0.5') >= 0 or (versioncmp($version, '8.2.11') >= 0 and versioncmp($version, '9.0.0') == -1)) ? {
  3:>> true  => '.',
  4:>> false => '-linux-2.6-',
  5:>> }
 => "."

and it prints a dot "." (with 9.4.0 and higher), which is correct.
But please feel free to double-check at the following URL, because it's really cluttered: https://www.splunk.com/en_us/download/previous-releases.html

[vchepkov]

I don't think this is specific for Debian, for example, rpm is also changed:
"https://download.splunk.com/products/splunk/releases/9.4.0/linux/splunk-9.4.0-6b4ebe426ca6.x86_64.rpm"

@vchepkov I don't think so. I quickly checked with puppet-debugger:

What I meant was, similar update should be applied to rpm based linux. I don't use module myself, but someone might benefit from it. Thanks.

[maxadamo]

@vchepkov I don't think so. I quickly checked with puppet-debugger:

What I meant was, similar update should be applied to rpm based linux. I don't use module myself, but someone might benefit from it. Thanks.

Now I understand. Thanks to you. That was my first thought but the RPM is unchanged.

[muncjack]

Hello,

I have added a entry to spec/spec_helper_acceptance.rb for 9.4.0, so I presum this will be added to the init test....

[maxadamo]

It looks like 9.4.0 is being tested now:
https://github.com/voxpupuli/puppet-splunk/actions/runs/12688237344/job/35364365883#step:7:1191

[siegy22]

It looks like they didn't change it for their RPMs: https://download.splunk.com/products/splunk/releases/9.4.0/linux/splunk-9.4.0-6b4ebe426ca6.x86_64.rpm

They changed it for RPMs earlier, and they completely removed the -linux-2.6- part from it. 🤦

So RPMs will stil work with 9.4.0, I just checked 😄

The change for the RPMs is here: https://github.com/voxpupuli/puppet-splunk/blob/master/manifests/params.pp#L323-L328