Add options to manage file system access options to Service #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in version 231, systemd provides options to manage file system access options to processes executed by systemd services. Adding these as valid options. See https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html#ReadWritePaths= for docs.
traylenator
reviewed
Apr 3, 2024
REFERENCE.md
Outdated
| @@ -2753,6 +2753,11 @@ Struct[{ | |||
| Optional['ProtectHome'] => Variant[Boolean, Enum['read-only', 'tmpfs']], | |||
| Optional['BindPaths'] => Variant[Stdlib::Unixpath,Pattern[/-\/.+/], Array[Variant[Stdlib::Unixpath,Pattern[/-\/.+/]],1]], | |||
| Optional['BindReadOnlyPaths'] => Variant[Stdlib::Unixpath,Pattern[/-\/.+/], Array[Variant[Stdlib::Unixpath,Pattern[/-\/.+/]],1]], | |||
| Optional['ReadWritePaths'] => Variant[Stdlib::Unixpath,Pattern[/-\/.+/], Array[Variant[Stdlib::Unixpath,Pattern[/-\/.+/]],1]], | |||
There was a problem hiding this comment.
Suggested change
| Optional['ReadWritePaths'] => Variant[Stdlib::Unixpath,Pattern[/-\/.+/], Array[Variant[Stdlib::Unixpath,Pattern[/-\/.+/]],1]], | |
| Optional['ReadWritePaths'] => Variant[Stdlib::Unixpath,Pattern[/^-\/.+/], Array[Variant[Stdlib::Unixpath,Pattern[/^-\/.+/]],1]], |
and similar. The - is always at the start.
There was a problem hiding this comment.
Thanks!
I updated the regular expression to accommodate this (from the systemd docs):
Paths in ReadWritePaths=, ReadOnlyPaths=, InaccessiblePaths=, ExecPaths= and NoExecPaths= may be prefixed with "-", in which case they will be ignored when they do not exist. If prefixed with "+" the paths are taken relative to the root directory of the unit, as configured with RootDirectory=/RootImage=, instead of relative to the root directory of the host (see above). When combining "-" and "+" on the same path make sure to specify "-" first, and "+" second.
Tested thus: https://rubular.com/r/oATb23JSEuE0MX
|
Could you add a few examples and counter examples to - https://github.com/voxpupuli/puppet-systemd/blob/master/spec/type_aliases/systemd_unit_service_spec.rb |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add options to manage file system access options to Service
Added in version 231, systemd provides options to manage file system access options to processes executed by systemd services. Adding these as valid options.
See https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html#ReadWritePaths= for docs.
This Pull Request (PR) fixes the following issues
n/a