(#29) Ensure vault is updated when version changes #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @bastelfreak ,are you able to review this PR? :) |
bastelfreak
changed the title
bastelfreak
changed the title
bastelfreak
reviewed
Jun 5, 2024
|
Hey @bastelfreak, is there anything else needed? :) Looking forwarding for merging. |
bastelfreak
reviewed
Jun 24, 2024
|
any updates @bastelfreak ? |
bastelfreak
pushed a commit
to bastelfreak/puppet-vault
that referenced
this pull request
Jul 12, 2024
This PR fixes the issue that version is not updated on parameter change. This is due the nature of creates parameter in archive. This PR is creating a fact of vaults version and compares it against the parameter. If parameter is newer it will download the archive and extract it. This will not reboot vault server. Please be aware to restart vault server, so vault sources the new binary. Fixes jsok#29 Cherry-picked and rebased from voxpupuli#52
Merged
bastelfreak
reviewed
Jul 12, 2024
bastelfreak
changed the title
bastelfreak
pushed a commit
to bastelfreak/puppet-vault
that referenced
this pull request
Jul 12, 2024
This is a cleanup for voxpupuli#52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR fixes the issue that version is not updated on parameter change.
This is due the nature of creates parameter in archive.
This PR is creating a fact of vaults version and compares it against the parameter.
If parameter is newer it will download the archive and extract it.
This will not reboot vault server.
Please be aware to restart vault server, so vault sources the new binary.
This Pull Request (PR) fixes the following issues
Fixes #29