Exported peers #82
Open
Exported peers #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declaring everything in hiera is not always convenient. This commit gives the choice to use exported resources so that peers declare themselves on each other.
|
I updated the requested files notably REFERENCES.md but it is still marked outdated. Not sure what can be done to fix it |
Before relying on it we need to check for its presence. The facts is actually available only after a Puppet pass which will deploy the keys on the target host
This usually happen when your bundle is outdated. Run |
smortex
reviewed
May 22, 2023
bastelfreak
reviewed
Jun 14, 2023
bastelfreak
reviewed
Jun 14, 2023
Comment on lines
+248
to
+249
| if 'wireguard_pubkeys' in $facts { | ||
| if $interface in $facts['wireguard_pubkeys'] { |
There was a problem hiding this comment.
Is there a benefit for checking if wireguard_pubkeys is in $facts and not directly using if $interface in $facts['wireguard_pubkeys']?
There was a problem hiding this comment.
wireguard_pubkeys fact is not present in facts on first run , so we cannot check is $interface is present in it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues