Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in metadata2gha options parsing #126

Conversation

h-haaks
Copy link
Contributor

@h-haaks h-haaks commented Apr 25, 2024

When gha-puppet invoke metadata2gha with changes in voxpupuli/gha-puppet#53 it will be invoked as `metadata2gha --beaker-hosts ""

We should not add the beaker_hosts key to options when option value is empty string.

@h-haaks h-haaks force-pushed the bug-in-metadata2gha-options-parsing branch from 3738a18 to b734ed2 Compare April 25, 2024 14:15
@bastelfreak bastelfreak added the bug Something isn't working label Apr 25, 2024
@h-haaks h-haaks merged commit 38b2500 into voxpupuli:master Apr 25, 2024
6 checks passed
@h-haaks h-haaks deleted the bug-in-metadata2gha-options-parsing branch April 25, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants