Rubocop: Update 1.28.2->1.50.0; requires Ruby 2.6 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to validate the rubocop.yml on a few modules before we can release this. some namespaces changed. |
bastelfreak
force-pushed
the
rubocop
branch
3 times, most recently
from
71f4845
to
78db5f4
Compare
rwaffen
approved these changes
Aug 11, 2023
rwaffen
reviewed
Aug 11, 2023
| s.add_runtime_dependency 'rubocop-rspec', '~> 2.10.0' | ||
| # newest versions that still support Ruby 2.6 | ||
| # jruby 9.3 in Puppetserver 7 is compatible with C Ruby 2.6 | ||
| s.add_runtime_dependency 'rubocop', '~> 1.50.0' |
There was a problem hiding this comment.
hmm had a look: 1.56 is latest
There was a problem hiding this comment.
yes, but that doesn't work on Ruby 2.6.
There was a problem hiding this comment.
ah okay. thats the thing.
jay7x
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.