Significant Performance Improvements #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were taking a massive performance hit by using shift. I've added a custom FastShiftArray to to bypass those limitations. Syntax macros processing of 10k lines went from 2216 ms to 156ms Now compiling 200k lines in 52 seconds (M1 Pro 16gb). Likely would have taken hours before these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Educated guess O(nlogn) to O(n) (VERY ROUGH GUESS)
We were taking a massive performance hit by using shift in the parser. I've removed shift where possible and I've added a custom FastShiftArray to to bypass those limitations where not possible.
Syntax macros processing of 10k lines went from 2216 ms to 156ms
Now compiling 200k lines in 52 seconds (M1 Pro 16gb).
Likely would have taken hours before these changes