Replaced the FieldType copy ctor with ctor for the prefix field and r…

…eplaced setting the field type parameters with setIndexOptions(). (opensearch-project#1901) Signed-off-by: Vesa Pehkonen <[email protected]>
vpehkone · May 3, 2022 · fddd2e0 · fddd2e0
1 parent f079ef3
commit fddd2e0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/...s/mapper-extras/src/main/java/org/opensearch/index/mapper/SearchAsYouTypeFieldMapper.java b/...s/mapper-extras/src/main/java/org/opensearch/index/mapper/SearchAsYouTypeFieldMapper.java
@@ -205,11 +205,8 @@ public SearchAsYouTypeFieldMapper build(Mapper.BuilderContext context) {
             ft.setIndexAnalyzer(analyzers.getIndexAnalyzer());
 
             // set up the prefix field
-            FieldType prefixft = new FieldType(fieldType);
-            prefixft.setStoreTermVectors(false);
-            prefixft.setStoreTermVectorPositions(false);
-            prefixft.setStoreTermVectorOffsets(false);
-            prefixft.setStoreTermVectorPayloads(false);
+            FieldType prefixft = new FieldType();
+            prefixft.setIndexOptions(fieldType.indexOptions());
             prefixft.setOmitNorms(true);
             prefixft.setStored(false);
             final String fullName = buildFullName(context);

diff --git a/...per-extras/src/test/java/org/opensearch/index/mapper/SearchAsYouTypeFieldMapperTests.java b/...per-extras/src/test/java/org/opensearch/index/mapper/SearchAsYouTypeFieldMapperTests.java
@@ -361,6 +361,9 @@ public void testTermVectors() throws IOException {
 
         PrefixFieldMapper prefixFieldMapper = getPrefixFieldMapper(mapper, "field._index_prefix");
         assertFalse(prefixFieldMapper.fieldType.storeTermVectors());
+        assertFalse(prefixFieldMapper.fieldType.storeTermVectorOffsets());
+        assertFalse(prefixFieldMapper.fieldType.storeTermVectorPositions());
+        assertFalse(prefixFieldMapper.fieldType.storeTermVectorPayloads());
     }
 
     public void testNorms() throws IOException {