Skip to content

Several changes for 3D Tiles api #114

Several changes for 3D Tiles api

Several changes for 3D Tiles api #114

Triggered via pull request January 14, 2024 16:40
Status Success
Total duration 3m 33s
Artifacts

dotnet.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

30 warnings
build (8.0.x, ubuntu-latest): build/SharpGLTF.CodeGen/SchemaReflection/SchemaTypesContext.cs#L66
Method UseBlittable passes parameter name 't' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
build (8.0.x, ubuntu-latest): build/SharpGLTF.CodeGen/SchemaDownload.cs#L20
Method 'void SchemaDownload.Syncronize(string remoteUrl, string localDirectory)' passes a literal string as parameter 'value' of a call to 'void Console.WriteLine(string? value)'. Retrieve the following string(s) from a resource table instead: "... Clone Completed". (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1303)
build (8.0.x, ubuntu-latest): tests/SharpGLTF.DownloadTestFiles/DownloadUtils.cs#L57
'WebClient.WebClient()' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.' (https://aka.ms/dotnet-warnings/SYSLIB0014)
build (8.0.x, ubuntu-latest): tests/SharpGLTF.DownloadTestFiles/DownloadUtils.cs#L15
Method SyncronizeGitRepository passes parameter name 'localDirectoryPath' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
build (8.0.x, ubuntu-latest): tests/SharpGLTF.DownloadTestFiles/DownloadUtils.cs#L46
Method DownloadFile passes parameter name 'localFilePath' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
build (8.0.x, ubuntu-latest): tests/SharpGLTF.DownloadTestFiles/ExampleFiles.cs#L70
Unused field '_BabylonJsInvalidFiles' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1823)
build (8.0.x, ubuntu-latest): src/SharpGLTF.Core/Collections/IChildOfDictionary.cs#L11
Rename type name IChildOfDictionary so that it does not end in 'Dictionary' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build (8.0.x, ubuntu-latest): src/SharpGLTF.Core/Collections/LinqDictionary.cs#L126
get_IsReadOnly creates an exception of type NotImplementedException, an exception type that should not be raised in a property. If this exception instance might be raised, use a different exception type, convert this property into a method, or change this property's logic so that it no longer raises an exception. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1065)
build (8.0.x, ubuntu-latest): src/SharpGLTF.Core/IO/JsonSerializable.cs#L416
'reader.TokenType == JSONTOKEN.StartObject' is always 'false'. Remove or refactor the condition(s) to avoid dead code. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1508)
build (8.0.x, ubuntu-latest): src/SharpGLTF.Core/Memory/MemoryImage.cs#L273
Modify 'get_IsValid' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
build (8.0.x, macos-latest): build/SharpGLTF.CodeGen/SchemaReflection/SchemaTypesContext.cs#L66
Method UseBlittable passes parameter name 't' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
build (8.0.x, macos-latest): build/SharpGLTF.CodeGen/SchemaDownload.cs#L20
Method 'void SchemaDownload.Syncronize(string remoteUrl, string localDirectory)' passes a literal string as parameter 'value' of a call to 'void Console.WriteLine(string? value)'. Retrieve the following string(s) from a resource table instead: "... Clone Completed". (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1303)
build (8.0.x, macos-latest): tests/SharpGLTF.DownloadTestFiles/DownloadUtils.cs#L57
'WebClient.WebClient()' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.' (https://aka.ms/dotnet-warnings/SYSLIB0014)
build (8.0.x, macos-latest): tests/SharpGLTF.DownloadTestFiles/ExampleFiles.cs#L70
Unused field '_BabylonJsInvalidFiles' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1823)
build (8.0.x, macos-latest): tests/SharpGLTF.DownloadTestFiles/DownloadUtils.cs#L15
Method SyncronizeGitRepository passes parameter name 'localDirectoryPath' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
build (8.0.x, macos-latest): tests/SharpGLTF.DownloadTestFiles/DownloadUtils.cs#L46
Method DownloadFile passes parameter name 'localFilePath' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
build (8.0.x, macos-latest): src/SharpGLTF.Core/Collections/IChildOfDictionary.cs#L11
Rename type name IChildOfDictionary so that it does not end in 'Dictionary' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build (8.0.x, macos-latest): src/SharpGLTF.Core/Collections/LinqDictionary.cs#L126
get_IsReadOnly creates an exception of type NotImplementedException, an exception type that should not be raised in a property. If this exception instance might be raised, use a different exception type, convert this property into a method, or change this property's logic so that it no longer raises an exception. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1065)
build (8.0.x, macos-latest): src/SharpGLTF.Core/Memory/MemoryImage.cs#L273
Modify 'get_IsValid' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
build (8.0.x, macos-latest): src/SharpGLTF.Core/Memory/MemoryImage.cs#L453
Modify '_IsKtx2Image' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
build (8.0.x, windows-latest): src/SharpGLTF.Core/Collections/IChildOfDictionary.cs#L11
Rename type name IChildOfDictionary so that it does not end in 'Dictionary' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build (8.0.x, windows-latest): src/SharpGLTF.Core/Validation/ValidationContext.Guards.cs#L138
Change the type of parameter 'gltfURI' of method 'ValidationContext.IsValidURI(ValueLocation, string, params string[])' from 'string' to 'System.Uri', or provide an overload to 'ValidationContext.IsValidURI(ValueLocation, string, params string[])' that allows 'gltfURI' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
build (8.0.x, windows-latest): src/SharpGLTF.Core/Validation/ValidationContext.Guards.cs#L132
Change the type of parameter 'gltfURI' of method 'ValidationContext.IsNullOrValidURI(ValueLocation, string, params string[])' from 'string' to 'System.Uri', or provide an overload to 'ValidationContext.IsNullOrValidURI(ValueLocation, string, params string[])' that allows 'gltfURI' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
build (8.0.x, windows-latest): src/SharpGLTF.Core/Schema2/Serialization.ReadContext.cs#L111
Change the type of parameter 'relativeUri' of method 'ReadContext.TryGetFullPath(string, out string)' from 'string' to 'System.Uri', or provide an overload to 'ReadContext.TryGetFullPath(string, out string)' that allows 'relativeUri' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
build (8.0.x, windows-latest): src/SharpGLTF.Core/Schema2/gltf.ExtraProperties.cs#L250
'val' is never 'null'. Remove or refactor the condition(s) to avoid dead code. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1508)
build (8.0.x, windows-latest): src/SharpGLTF.Core/Schema2/gltf.Material.cs#L132
In member void Material.OnValidateContent(ValidationContext result), change parameter name result to validate in order to match the identifier as it has been declared in void ExtraProperties.OnValidateContent(ValidationContext validate) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
build (8.0.x, windows-latest): src/SharpGLTF.Core/Schema2/Serialization.ReadSettings.cs#L241
Member 'OnDeserializationCompleted' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
build (8.0.x, windows-latest): src/SharpGLTF.Core/Schema2/gltf.MaterialsFactory.cs#L632
Method OnValidateContent passes 'EmissiveStrength' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
build (8.0.x, windows-latest): src/SharpGLTF.Core/Schema2/gltf.MaterialsFactory.cs#L485
Method OnValidateContent passes 'IndexOfRefraction' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
build (8.0.x, windows-latest): src/SharpGLTF.Core/Memory/MemoryImage.cs#L273
Modify 'get_IsValid' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)