Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OUT_OF_MEMORY job state #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

nktl
Copy link

@nktl nktl commented Dec 23, 2021

A quick patch to support OUT_OF_MEMORY job state - visibility of which is especially useful when task/cgroup plugin is used with ConstrainRAMSpace=YES option (in such case cgroup will oomkill the job if it exceeds requested memory)

A quick patch to support OUT_OF_MEMORY job state - visibility of which is especially useful when `task/cgroup` plugin is used with `ConstrainRAMSpace=YES` option (in such case cgroup will kill the job if it exceeds requested memory)
@uberspot
Copy link

Can we prioritize this for merging please?

@mtds mtds self-assigned this May 20, 2022
@mtds
Copy link
Collaborator

mtds commented May 20, 2022

Can we prioritize this for merging please?

My main issue with this PR is that most of the changes are due to poor formatting:

  1. Change in NewQueueCollector() is basically only one line but the commit will re-write the entire function block.
  2. Same goes for the QueueCollector struct: only one line needs to be changed not the entire structure.

@nktl
Copy link
Author

nktl commented May 31, 2022

Hey, fixed the indentation / formatting as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants