-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hemppa as lib #253
Draft
alertrix
wants to merge
58
commits into
vranki:master
Choose a base branch
from
alertrix:hemppa-as-lib
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
hemppa as lib #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r this package, so it is less likely to conflict with other packages
…cript in "bot.py"
…pa/modules/bot.py
Optional dependencies for the mastodon module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original version of hemppa requires the users code to be added into the existing repository. To keep the repository of a new project clean, i suggest packaging the project as lib, so it can be installed into any other project.
Creating a new project is as easy as installing hemppa…
… adding the files
… adding the content
into my_module/my_command.py
… starting the bot using the script defined in pyproject.toml
and enabling the module in matrix:
What still needs to be done
General consideration
In some environments some of the builtin dependencies might be illegal or require very complex regulation (eg google calendar under the gdpr in europe), so these dependencies should be dropped (or excluded into separate repositories, this pull request enables to install other modules using pip as well). This pull request only includes the bare bones dependencies (see below).
Specific instructions
The current dependencies still need to be added to the new format as demonstrated in this pull request for the mastodon module.