Adds RemoveMatchedService(). fixes #41 #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momo-the-monster
approved these changes
Feb 26, 2024
Contributor
There was a problem hiding this comment.
First off - thanks for all your PRs @joreg, and sorry it's taken me so long to review them! I should be able to roll through them all in the next few weeks.
This one makes sense to me - it does look like checking for a TTL of 0 is a pretty standard way to do this. I have a follow-up PR that adds tests for MeaMod to add and drop an advertised service that rely on this new functionality.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following the explanation here that a TTL of 0 means that a service was unadvertised.