Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to check PRs (build/test/check_fmt) #18

Merged
merged 6 commits into from
Sep 28, 2024

Conversation

0xkubectl
Copy link
Contributor

@0xkubectl 0xkubectl commented Jul 23, 2024

Add a simple workflow to cross check if PRs and commits to main work.
Based on this: https://github.com/C0D3-M4513R/DexProtectOscRS/blob/main/.github/workflows/rust.yml

Depends on #20

rust-toolchain.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@C0D3-M4513R C0D3-M4513R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixes #17 #20 and #19 in now.
I thought this pr was supposed to be a ci only change?

@0xkubectl 0xkubectl force-pushed the kubectl/add-ci branch 2 times, most recently from 98edd38 to 6567661 Compare July 27, 2024 19:33
@0xkubectl
Copy link
Contributor Author

Mixes #17 #20 and #19 in now. I thought this pr was supposed to be a ci only change?

The branch was forked of #17, didnt notice. Fixed.

Copy link
Collaborator

@C0D3-M4513R C0D3-M4513R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine enough for now.
One thing, that doesn't really sit right with me is the on push trigger though, since that'll cause duplicate builds when an update is made to the specification.

@C0D3-M4513R C0D3-M4513R merged commit e1a32ba into vrchatapi:main Sep 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants