Deberta v2 support #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozistr
reviewed
Jul 19, 2025
Collaborator
kozistr
left a comment
kozistr
left a comment
There was a problem hiding this comment.
great work! I've just left some reviews, and will get back to you when I have some time on my hands :)
Owner
Author
|
He @kozistr, I finally got some time to go through this and started addressing your comments. I will mostly raise a PR against the main repo this week, so hoping to get more feedback from you there! |
Owner
Author
|
I've addressed all the comments in this PR. closing this in favor of huggingface#746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kozistr thanks again for agreeing to help out!