Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge some RUN commands in base-ops Dockerfile #267

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

AndresTanasijczuk
Copy link
Contributor

No description provided.

@garciagenrique
Copy link
Member

Thanks for the contribution @AndresTanasijczuk !

Couple of small things:

  • Just added you to the vre-hub organisation (you should have received and email). Contributions coming from people outside the org don't trigger checks (CI).
  • I will be skipping this time (as stated in the documentation) that any change to vre-base-ops must imply a new tag. Changes in the dockerfile won't change the functionality of the container (so avoiding a new set of containers).

@garciagenrique garciagenrique merged commit 3de9699 into vre-hub:main Jan 12, 2024
2 checks passed
@AndresTanasijczuk AndresTanasijczuk deleted the base-ops_dockerfile branch January 15, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants