Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Consistent/Polished wording in Docs & Settings #562

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

RyderForReal
Copy link

First of - thanks a lot for your work on this project. I recently started using it since I generally prefer to self-host things and it has been incredibly useful.

I figured that I'd make the titles and descriptions in the docs and settings more consistent and reword some cases of awkward phrasing. I'm still working on this PR, but was wondering if you had a preference for which kind of spelling to use (American English or British English). I'd just run a quick search & replace when I'm done with my work to make this consistent as well.

Thanks in advance.

@RyderForReal
Copy link
Author

Notes to self:

  • Fix the translation keys
  • Parity between settings.md and the actual settings

@RyderForReal
Copy link
Author

Question regarding the cache size setting (Advanced -> Memory Cache):

The old description is "(Mega chars)" (see

), implying million characters (mega = million).

However, when reading through the code that refers back to this setting, specifically LRUCache, I don't see a mention of million. Am I correct in assuming that the "million" can be removed from the description?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant