-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Consistent/Polished wording in Docs & Settings #562
Draft
RyderForReal
wants to merge
17
commits into
vrtmrz:main
Choose a base branch
from
RyderForReal:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes to self:
|
Question regarding the cache size setting (Advanced -> Memory Cache): The old description is "(Mega chars)" (see
However, when reading through the code that refers back to this setting, specifically LRUCache, I don't see a mention of million. Am I correct in assuming that the "million" can be removed from the description? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of - thanks a lot for your work on this project. I recently started using it since I generally prefer to self-host things and it has been incredibly useful.
I figured that I'd make the titles and descriptions in the docs and settings more consistent and reword some cases of awkward phrasing. I'm still working on this PR, but was wondering if you had a preference for which kind of spelling to use (American English or British English). I'd just run a quick search & replace when I'm done with my work to make this consistent as well.
Thanks in advance.