Sweep: Connection with InfluxDB needs Authorization API key, not user/password authentification (✓ Sandbox Passed) #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-ai[bot]](https://avatars.githubusercontent.com/in/307814?s=60&v=4){kind=small}
Rollback Files For Sweep
This is an automated message generated by Sweep AI. |
Apply Sweep Rules to your PR?
This is an automated message generated by Sweep AI. |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -79,6 +85,11 @@ class HttpService { | |||
| u: this.context.username, | |||
| p: this.context.password, | |||
| }; | |||
| } else if (this.context.version == 2) { | |||
| const params = { | |||
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| p: this.context.password, | ||
| }; | ||
|
|
||
| let params = {}; |
There was a problem hiding this comment.
'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| // Setting Authorization header for API token-based authentication | ||
| if(this.context.apiToken) { | ||
| axiosOptions.headers = { | ||
| Authorization: `Token ${this.context.apiToken}`, |
There was a problem hiding this comment.
'template literal syntax' is only available in ES6 (use 'esversion: 6').
Open
6 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Feedback (click)
Description
This pull request updates the HttpService class in the src/http.service.js file to make the necessary changes for connecting with InfluxDB using an API token for authentication instead of username and password. It also updates the _buildInfluxDBUrl and _writeData methods to handle the changes in authentication based on the InfluxDB version.
Summary
Fixes #45.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: