Add $code parameter to disconnect, reset SEQ on new session, don't re-fetch websocket_url when resuming, make 1000 & 1001 resumable #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elated to vsTerminus#37" This reverts commit 77b97a1.
This reverts commit 8e881d6.
be resumable if 'd' is true when 'op' is 9, fix some logging output, remove some old variables from Identify hash
re-fetch websocket_url when resuming, make 1000 & 1001 resumable
|
ccfbf90 slipped in here. Revert that one (or not), as you wish. |
|
I've made some of these changes in my local copy. I'll likely end up just closing the pull request once I've pushed my own changes, but thank you, this was helpful. |
|
$code parameter added in fa2ed04 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$codeparameter to$discord->disconnect()to allow for normal closures from a client, e.g. to gracefully close with 1000 after SIGINTSEQon new sessions so the heartbeating does not use the oldSEQID until the correct one is received againwebsocket_urlwhen resuming. Since a while the Mojo UA sometimes gives me aPremature connection closeinsub gateway, not sure why - so this is a workaround. But I'm pretty sure that if this url ever changes it would require a new session anyways so why not use the cached one on resume.