Skip to content

Commit

Permalink
Remove v1alpha1 for objects from webhook definition
Browse files Browse the repository at this point in the history
If the v1alpha1 version is not available, the webhook will fail.
We will therefore remove it here, and manually add it where required

Signed-off-by: Nicolas Bigler <[email protected]>
  • Loading branch information
TheBigLee committed Oct 31, 2024
1 parent 12d2103 commit c58e5a1
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
19 changes: 0 additions & 19 deletions config/controller/webhooks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -99,25 +99,6 @@ webhooks:
resources:
- objects
sideEffects: None
- admissionReviewVersions:
- v1
clientConfig:
service:
name: webhook-service
namespace: system
path: /validate-kubernetes-crossplane-io-v1alpha1-object
failurePolicy: Fail
name: objectsv1alpha1.vshn.appcat.vshn.io
rules:
- apiGroups:
- kubernetes.crossplane.io
apiVersions:
- v1alpha1
operations:
- DELETE
resources:
- objects
sideEffects: None
- admissionReviewVersions:
- v1
clientConfig:
Expand Down
1 change: 0 additions & 1 deletion pkg/controller/webhooks/object.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
ctrl "sigs.k8s.io/controller-runtime"
)

//+kubebuilder:webhook:verbs=delete,path=/validate-kubernetes-crossplane-io-v1alpha1-object,mutating=false,failurePolicy=fail,groups="kubernetes.crossplane.io",resources=objects,versions=v1alpha1,name=objectsv1alpha1.vshn.appcat.vshn.io,sideEffects=None,admissionReviewVersions=v1
//+kubebuilder:webhook:verbs=delete,path=/validate-kubernetes-crossplane-io-v1alpha2-object,mutating=false,failurePolicy=fail,groups="kubernetes.crossplane.io",resources=objects,versions=v1alpha2,name=objects.vshn.appcat.vshn.io,sideEffects=None,admissionReviewVersions=v1

//+kubebuilder:rbac:groups=syn.tools,resources=compositeredisinstances,verbs=get;list;watch;patch;update
Expand Down

0 comments on commit c58e5a1

Please sign in to comment.